Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise string / dict import, maybe best to allow both everywhere? #8

Open
aportagain opened this issue May 28, 2018 · 0 comments
Assignees

Comments

@aportagain
Copy link
Member

On one hand, you could argue that the actual string parsing should usually be handled outside of the cfjson package. Sometimes that's actually required, for example when dealing with paged output like the observations API currently provides (list of cfjson objects vs. a single cfjson object). But on the other hand, there's probably many cases where it would be convenient to have everything handled by a single call. Off the top of my head I'm not sure whether the "standard" cfjson packages have all the functionality we need?

Could we just check for str / unicode (buffer? file? anything else?) in all the import functions / methods, and otherwise assume the input is alread a dictionary?

@aportagain aportagain self-assigned this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant