Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not showing after ensureSignedIn #286

Closed
ddeklerk opened this issue Feb 18, 2015 · 2 comments
Closed

Error message not showing after ensureSignedIn #286

ddeklerk opened this issue Feb 18, 2015 · 2 comments

Comments

@ddeklerk
Copy link

Hello,

When I have configured a route like this

Router.route('profile', {
    onBeforeAction: AccountsTemplates.ensureSignedIn
});

and try to access the page I get the sign-in page as expected. However, when I enter incorrect username or password, the original error message stays the same. So "Must be logged in" instead of "Login forbidden".

By testing it in the boilerplates provided here it seems that it is a bug introduced after those were made. When I clone that repo and log in after a ensureSignedIn has triggered, I get the appropriate message when entering the wrong information. But when I update the meteor packages and try again, I am stuck with the origional error.

@splendido
Copy link
Member

Ha, I see!

This is a regression introduced with db59f14.

I'll revert back to a working status, but #278 remains unfixed!

I'm starting to realize we'd need to use both onRun and onBeforeAction to get this working properly...
This can be achieved by creating an IR plugin

@splendido
Copy link
Member

...I've eventually did it:

see e9ee6d2 and Content Protection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants