-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added new actions for metadata program #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thanks for doing that, have no objections.
We need to think about tests speed.
No prob - one team one dream 🙏 Re tests - if the delays bother you, I would honestly run them once (now) and comment out the deserialization & state checking parts that take extra time. The fact that the transaction goes through without errors should give you 95% comfort that it's doing what it must. Program endpoints don't change - when new ones are added the old are simply renamed "deprecated", so if it worked once, in theory should work forever. Another much more involved option is to do a local validator for tests. Tbh that's the right way to do it, but I get the dev overhead associated with that, and that it might not be a priority right now. Just my 2c |
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've been using
metaplex/js
for a project and ended up writing some of the actions that were missing.A few things to point out:
UpdateMetadata
, where because the below 2 lines were set to= null
, borsh wasn't serializing data properly.= null
was needed. Through trial and error removing it seems to fix the issue and didn't break any other tests.Finally, I've left a few comments in the code to clarify parts I found confusing when coding this. I noticed the repo is basically comment-free - if that's an intentional decision, more than happy to remove. But I do think they're useful.
Hope this is useful!