Mint NFT Action

[kespinola]

Changes

Bundle the available transaction instructions into a single action for creating a master edition NFT with some max supply based on a metadata JSON URL.

Questions

• What are your opinions on the action parameters and response?
• Should there be separate actions for generating metadata and master editions?
• I pulled the convention of reading the metadata fields from a URL from the metaplex cli. Good or bad?

[zaxozhu]

Looks good!

• What are your opinions on the action parameters and response?
  I think that's how what we want it to be.

• Should there be separate actions for generating metadata and master editions?
  I think, no. It's premature. That one, who will decide to have an action to generate the metadata, can just extract it from here and create a new action.

• I pulled the convention of reading the metadata fields from a URL from the metaplex cli. Good or bad?
  Looks great

[kurpav]

I guess amount should be configurable

[kurpav]

I'm not that aware of the flow, but can we mint a few items? And does it makes sense?

[zaxozhu]

No, let's stick to 1 for now

[kespinola]

@m-sebastiyan and Metaplex team this is ready for final review.

Unfortunately, batching even 2 nft instruction bundles into a single transaction exceeded the max instruction size so going with the single mint action.

[kespinola]

@b2kdaman that was an existing reference that I was looking to trim down to just the updateMetadata test since the mintNFT now bundles up the instructions but update is dependent on the create. I'm going to leave it in until an updateMetadata action is added.

Also in terms of the interface do what do you all think of a class method on something like metadata or master edition?

`const {txtId} = await MasterEdition.mint(params)

It doesn't return an instance of the class which is the normal output of such methods. I'm good either way just see this pattern used already in the sdk.

[kespinola]

Can I get some more clarity on parameterizing the amount?

#51 (review)

[zaxozhu]

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[monomadic]

FWIW there's a bug in this code when the creators array is missing or empty. The metaplex NFT standard supports this, but this code will throw this error:

TypeError: Cannot read properties of undefined (reading 'reduce')
    at /Users/nom/Workspaces/solana.workspace/solana-examples/node_modules/@metaplex/js/src/actions/mintNFT.ts:53:33