Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote DNS doesn't work for node.js #321

Closed
eyalb181 opened this issue Sep 4, 2022 · 2 comments · Fixed by #324
Closed

Remote DNS doesn't work for node.js #321

eyalb181 opened this issue Sep 4, 2022 · 2 comments · Fixed by #324
Labels
bug Something isn't working
Milestone

Comments

@eyalb181
Copy link
Member

eyalb181 commented Sep 4, 2022

Bug Description

@aviramha encountered the following error when enabling remote DNS on a Node.js app:

2022-09-02T16:09:31.397836Z ERROR mirrord_layer::error: Error occured in Layer >> ResponseError(RemoteIO(RemoteIOError { raw_oserror: None, kind: Other })) Assertion failed: (!"unknown EAI* error code"), function uv__getaddrinfo_translate_error, file ../deps/uv/src/unix/getaddrinfo.c, line 90. [1] 90277 abort mirrord exec -s "*" -o -d -p front-end-6585d48b5c-v6q2h -n sock-shop -- node node dns with uvloop fails

Steps to Reproduce

Enable remote DNS on a Node.js app (that does some DNS resolving)

Backtrace

No response

Relevant Logs

No response

Your operating system and version

N/A

Local process

N/A

Local process version

No response

Additional Info

No response

@eyalb181 eyalb181 added the bug Something isn't working label Sep 4, 2022
@eyalb181 eyalb181 added this to the MVP milestone Sep 4, 2022
@aviramha
Copy link
Member

aviramha commented Sep 4, 2022

I found one issue, and that's the DNS being resolved in the agent context instead of the impersonated container context.
Another theoretical issue is that the error is IO and not not found for some reason.. might be related to the first issue.

@aviramha
Copy link
Member

aviramha commented Sep 4, 2022

Okay, besides the first theory, the error code didn't propagate but even when it did, macOS expects different codes than Linux so it needs more translation. PR incoming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants