Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steal based on HTTP Path Filter #1512

Closed
2 tasks done
aviramha opened this issue Jun 7, 2023 · 2 comments
Closed
2 tasks done

Steal based on HTTP Path Filter #1512

aviramha opened this issue Jun 7, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@aviramha
Copy link
Member

aviramha commented Jun 7, 2023

Currently we support filtering based on HTTP headers. Some of the users asked to support stealing based on the path accessed.

@aviramha aviramha added the enhancement New feature or request label Jun 7, 2023
@aviramha
Copy link
Member Author

We probably need to deprecate the old filter config, since it's "explicitly" http header. Having said that, would we want the filters to be or / and / or mutual exclusive? like if user specifies a http header filter and path header, should it be matching both or only one or should we just error for now?

@eyalb181
Copy link
Member

Personally I don't see a use case for either, and would rather error out until a user asks for it than support a use case we don't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants