Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsidering the way background tasks are handled #1287

Closed
Razz4780 opened this issue Apr 12, 2023 · 3 comments
Closed

Reconsidering the way background tasks are handled #1287

Razz4780 opened this issue Apr 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Razz4780
Copy link
Contributor

Right now mirrord agent uses 3 global background tasks (dns, sniffer and stealer) and 2 per-client background tasks (tcp and udp). All tasks are run in their own tokio runtimes constructed with Builder::new_multi_thread, which spawns nproc threads. Main function is also run in a multi-threaded runtime. That means that agent uses (4 + clients) * nproc threads. Maybe we could consider using single-threaded runtimes?

@Razz4780 Razz4780 added the enhancement New feature or request label Apr 12, 2023
@eyalb181
Copy link
Member

eyalb181 commented May 4, 2023

Seems premature at this point - not something our users will really feel the effect of?

@Razz4780
Copy link
Contributor Author

Razz4780 commented May 8, 2023

Seems premature at this point - not something our users will really feel the effect of?

Just something I noticed when working with the agent. The change would be very simple - using different tokio runtime flavor.

@Razz4780
Copy link
Contributor Author

Closed with #1497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants