Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP macOS - add fallback to arm64 #1155

Closed
aviramha opened this issue Mar 6, 2023 · 2 comments
Closed

SIP macOS - add fallback to arm64 #1155

aviramha opened this issue Mar 6, 2023 · 2 comments
Assignees

Comments

@aviramha
Copy link
Member

aviramha commented Mar 6, 2023

Currently we extract x64 binary but sometimes arm64 is available so we can avoid emulation. In this case we should extract the arm64 binary and patch it.

@t4lz
Copy link
Member

t4lz commented Apr 13, 2023

Almost done, just one concern, @aviramha:
Isn't it possible that there are going to be fat binaries with arm64 binaries included in them, on macs with intel chips?
In that case, if we prefer the arm64 binaries over the x64 binaries and use them, the patched arm64 binary is not going to be able to run on the intel x64 mac, is it?

Should we choose the binary according to the system's architecture?

@aviramha
Copy link
Member Author

Almost done, just one concern, @aviramha: Isn't it possible that there are going to be fat binaries with arm64 binaries included in them, on macs with intel chips? In that case, if we prefer the arm64 binaries over the x64 binaries and use them, the patched arm64 binary is not going to be able to run on the intel x64 mac, is it?

Should we choose the binary according to the system's architecture?

That's correct.. That should be probably done in compile time, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants