Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel run on extension/plugin errors instead of running without mirrord #7

Closed
t4lz opened this issue May 17, 2023 · 0 comments · Fixed by #86
Closed

Cancel run on extension/plugin errors instead of running without mirrord #7

t4lz opened this issue May 17, 2023 · 0 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@t4lz
Copy link
Member

t4lz commented May 17, 2023

If something goes wrong before starting the run with mirrord, we don't load into the process, but we do let the program start without mirrord.
I think we should instead cancel the run altogether.

If a user is trying to run with mirrord, running without mirrord is not going to help them at all.
Moreover, it might cause problematic situations, for example if the program has side effects that are meant to happen remotely - it might be bad for them to happen locally (e.g. overriding files).

I didn't check what happens on vscode, please edit this issue accordingly if you know.

@t4lz t4lz added the enhancement New feature or request label May 17, 2023
@aviramha aviramha transferred this issue from metalbear-co/mirrord Jun 17, 2023
@Razz4780 Razz4780 mentioned this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants