Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env check for enabling mirrord explicitly via run configuration #231

Closed
aviramha opened this issue Jan 10, 2024 · 2 comments · Fixed by #232
Closed

Add env check for enabling mirrord explicitly via run configuration #231

aviramha opened this issue Jan 10, 2024 · 2 comments · Fixed by #232

Comments

@aviramha
Copy link
Member

If user sets MIRRORD_ACTIVE=1 in their run configuration's environment, mirrord should run even if button is disabled.

@t4lz
Copy link
Member

t4lz commented Jan 10, 2024

How about also accepting MIRRORD_ACTIVE=0 to disable mirrord for a run configuration even if the button is enabled?

@aviramha
Copy link
Member Author

@t4lz I actually thought about it but felt like it's an over kill - they should just ignore the button and use the explicit for on always, not having means off for them.. but if user asks maybe I'll think about it again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants