From 484ae622cb769b532f772351a75f3662a7f1daa7 Mon Sep 17 00:00:00 2001 From: Michael Wiencek Date: Mon, 19 Mar 2018 11:54:39 -0500 Subject: [PATCH] Remove leading space from bracketed output See the comments in https://github.com/metabrainz/musicbrainz-server/pull/630 --- root/static/scripts/common/components/EntityLink.js | 4 ++-- root/static/scripts/common/utility/bracketed.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/root/static/scripts/common/components/EntityLink.js b/root/static/scripts/common/components/EntityLink.js index 78a2c14add9..35297a2a44c 100644 --- a/root/static/scripts/common/components/EntityLink.js +++ b/root/static/scripts/common/components/EntityLink.js @@ -51,7 +51,7 @@ const EventDisambiguation = ({event}: {|+event: EventT|}) => { } return ( - {dates ? bracketed(dates) : null} + {dates ? ' ' + bracketed(dates) : null} {event.cancelled ? : null} @@ -122,7 +122,7 @@ const EntityLink = ({ } if (entity.entityType === 'artist' && !nonEmpty(hover)) { - hover = entity.sort_name + bracketed(comment); + hover = entity.sort_name + (comment ? ' ' + bracketed(comment) : ''); } if (entity.entityType === 'area') { diff --git a/root/static/scripts/common/utility/bracketed.js b/root/static/scripts/common/utility/bracketed.js index f3546398647..d2c5d97efac 100644 --- a/root/static/scripts/common/utility/bracketed.js +++ b/root/static/scripts/common/utility/bracketed.js @@ -16,7 +16,7 @@ type Args = $Shape<{ export default function bracketed(text: ?ReactNode, args: Args = {}) { if (text) { - return l(' ({text})', {text, ...args}); + return l('({text})', {text, ...args}); } return ''; }