Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-Llama models #965

Open
terrytangyuan opened this issue Feb 5, 2025 · 4 comments
Open

Support non-Llama models #965

terrytangyuan opened this issue Feb 5, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@terrytangyuan
Copy link
Collaborator

terrytangyuan commented Feb 5, 2025

🚀 Describe the new functionality needed

We currently have a workaround to support non-Llama models through the remote vLLM provider but it would be great to support this officially.

For inline vLLM provider, this is work-in-progress: #880

Let's use this issue to discuss any proposals and technical considerations.

@terrytangyuan terrytangyuan added the enhancement New feature or request label Feb 5, 2025
@sanderjson
Copy link

sanderjson commented Feb 5, 2025

@sanderjson Stay tuned. until now we have exclusively supported llama models only, but we will be making a few changes to enable other models soon -- as early as next couple days. (last week)

#721 (comment)

@nathan-weinberg
Copy link
Contributor

Should include updates to the Philosophy section here as well: https://llama-stack.readthedocs.io/en/latest/introduction/index.html#our-philosophy

@bbrowning
Copy link
Contributor

Maybe enabling the usage of non-Llama generally as simple as removing the ValueError thrown here:

raise ValueError(
f"Model '{model.provider_resource_id}' is not available and no llama_model was specified in metadata. "
"Please specify a llama_model in metadata or use a supported model identifier"
)
At that point in the code we've checked the model aliases across the providers, didn't find a matching alias, so instead of raising the error we could just fallback to using the provided model.provider_resource_id and assume the user knows enough to register a model id that matches something valid in their backend provider.

That would let us still take advantage of the aliases for all well-known Llama models, but let users attempt to use other models that their providers support without throwing an error.

@terrytangyuan
Copy link
Collaborator Author

terrytangyuan commented Feb 22, 2025

Non-Llama models are supported now in several inference providers (including remote vLLM) after merging #1200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants