fix: examples: refactor agent_store method to use Document instead of Attachment #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Attachment This change updates the `chat` method in `AgentStore` to use `Document` instead of `Attachment` when handling file inputs. - Removed the unused `Attachment` import. - Renamed the `attachments` parameter to `documents` for clarity. - Updated the logic to convert file inputs into `Document` instances instead of `Attachment`. - Ensured proper handling of `mime_type`, currently hardcoded as `text/plain`. This refactor aligns with API expectations and improves consistency in document handling.
EmilienM
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change updates the
chatmethod inAgentStoreto useDocumentinstead ofAttachmentwhen handling file inputs.Attachmentimport.attachmentsparameter todocumentsfor clarity.Documentinstances instead ofAttachment.mime_type, currently hardcoded astext/plain.This refactor aligns with API expectations and improves consistency in document handling.
Related change: https://github.com/meta-llama/llama-stack-client-python/pull/73/files#diff-b38e3fcdf146b8d15b63f07ee0a4b6f0080d202da0381373bac8e8edf289f5c1L71
Closes #178