Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#bug; Aave MintToTreasury() not being properly tracked #2055

Closed
melotik opened this issue Apr 24, 2023 · 4 comments · Fixed by #2259
Closed

#bug; Aave MintToTreasury() not being properly tracked #2055

melotik opened this issue Apr 24, 2023 · 4 comments · Fixed by #2259
Assignees
Labels
bug Something isn't working p0 high priority

Comments

@melotik
Copy link
Contributor

melotik commented Apr 24, 2023

aTokens being minted to the treasury are not being tracked as positions since we are dismissing mint transfer events.

To fix this we need to add a check to allow position updates on mints that go to a treasury address.

Without this fix, treasury addresses will not have accurate position.balance / positionSnapshots

@melotik melotik added the bug Something isn't working label Apr 24, 2023
@melotik
Copy link
Contributor Author

melotik commented Apr 24, 2023

@bye43 we should do this after #1993 is complete and we know it is correct

@melotik
Copy link
Contributor Author

melotik commented Apr 25, 2023

We can actually just watch this event and update the respective treasury supply position when executed

@melotik
Copy link
Contributor Author

melotik commented Apr 25, 2023

Treasury is set on AToken init and cannot be changed: https://github.com/aave/aave-v3-core/blob/master/contracts/protocol/tokenization/AToken.sol#L76

@bye43
Copy link
Contributor

bye43 commented May 8, 2023

This will be done after #1519 is closed

@bye43 bye43 moved this from Discussions to Backlog in Subgraph Development May 8, 2023
@bye43 bye43 assigned tnkrxyz and unassigned bye43 May 22, 2023
@bye43 bye43 assigned dhruv-chauhan and unassigned tnkrxyz Jun 30, 2023
@bye43 bye43 moved this from Backlog to Assigned for Fixes in Subgraph Development Jun 30, 2023
@bye43 bye43 added p1 medium priority p0 high priority and removed p1 medium priority labels Jun 30, 2023
@melotik melotik moved this from Assigned for Fixes to In Review in Subgraph Development Jul 6, 2023
@github-project-automation github-project-automation bot moved this from In Review to Deploy To Hosted Service in Subgraph Development Jul 19, 2023
@melotik melotik moved this from Deploy To Hosted Service to Done in Subgraph Development Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 high priority
Projects
Development

Successfully merging a pull request may close this issue.

4 participants