Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commitDate in goreleaser #92

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix: commitDate in goreleaser #92

merged 1 commit into from
Apr 5, 2022

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Apr 5, 2022

Noticed that konvoy and here had an incorrect commitDate: "1970-01-01T00:00:00Z":

➜ ./dkp version -o yaml
diagnose:
  commitDate: "2022-03-21T16:52:29Z"
  compiler: gc
  gitCommit: 947e77ab077fab6f1cd528421cae7173ef08efd2
  gitTreeState: ""
  gitVersion: v0.0.0-dev.0
  goVersion: go1.17.6
  major: "0"
  minor: "0"
  platform: darwin/amd64
dkp:
  commitDate: "2022-04-04T00:51:14Z"
  compiler: gc
  gitCommit: 776919234cb227be7a1961fb37995a82ef1b4f28
  gitTreeState: ""
  gitVersion: v0.0.0-dev.0
  goVersion: go1.17.8
  major: "0"
  minor: "0"
  platform: darwin/amd64
kommander:
  commitDate: "2022-04-01T18:45:56Z"
  compiler: gc
  gitCommit: a73ad71be53f31a48f81c1c6fdc42b15c909e52a
  gitTreeState: ""
  gitVersion: v2.2.0-dev
  goVersion: go1.17.8
  major: "2"
  minor: "2"
  platform: darwin/amd64
konvoy:
  commitDate: "1970-01-01T00:00:00Z"
  compiler: gc
  gitCommit: 31dda110fe0483dc753de8500be218fd8e1d6bb0
  gitTreeState: ""
  gitVersion: v0.0.0-dev.0
  goVersion: go1.17.8
  major: "0"
  minor: "0"
  platform: darwin/amd64
mindthegap:
  commitDate: "1970-01-01T00:00:00Z"
  compiler: gc
  gitCommit: 51c911c08ab6837b70942f87648cc99aca14722c
  gitTreeState: ""
  gitVersion: v0.6.9
  goVersion: go1.17.8
  major: "0"
  minor: "6"
  platform: darwin/amd64

@github-actions github-actions bot added the fix label Apr 5, 2022
@jimmidyson jimmidyson merged commit 017d2f3 into main Apr 5, 2022
@jimmidyson jimmidyson deleted the dkoshkin/commitDate branch April 5, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants