Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Ability to choose between '-sf' and '-st' HAProxy signal flags #318

Closed
h0tbird opened this issue Sep 21, 2016 · 2 comments
Closed

Ability to choose between '-sf' and '-st' HAProxy signal flags #318

h0tbird opened this issue Sep 21, 2016 · 2 comments
Labels
enhancement

Comments

@h0tbird
Copy link

h0tbird commented Sep 21, 2016

marathon-lb has the -sf flag hard-coded. Would you consider making it configurable?
I think this will be useful to people running long-lived TCP connections.

Ideally I would add a timeout to the -sf flag after which it will fail-over to the -st behavior. But this is a request for the upstream HAProxy project. What do you think?
@h0tbird h0tbird mentioned this issue Sep 21, 2016
Closed
brndnmtthws added a commit that referenced this issue Sep 26, 2016
@brndnmtthws
Optionally send SIGTERM after reload.
ef22fbf 
This is to address issues #5, #71, #267, #276, and #318.
brndnmtthws added a commit that referenced this issue Sep 26, 2016
@brndnmtthws
Optionally send SIGTERM after reload.
e273faf 
This is to address issues #5, #71, #267, #276, and #318.
@brndnmtthws brndnmtthws mentioned this issue Sep 26, 2016
Merged
brndnmtthws added a commit that referenced this issue Sep 26, 2016
@brndnmtthws
Optionally send SIGTERM after reload.
806d93a 
This is to address issues #5, #71, #267, #276, and #318.
@brndnmtthws
Copy link
Contributor

I'm not opposed to it, but I think I prefer #321.

@h0tbird
Copy link
Author

h0tbird commented Sep 27, 2016

I think it will work for me too.

@h0tbird h0tbird closed this as completed Sep 27, 2016
brndnmtthws added a commit that referenced this issue Sep 29, 2016
@brndnmtthws
Optionally send SIGTERM after reload.
f1df667 
This is to address issues #5, #71, #267, #276, and #318.
brndnmtthws added a commit that referenced this issue Sep 29, 2016
@brndnmtthws
Optionally send SIGTERM after reload.
568ec34 
This is to address issues #5, #71, #267, #276, and #318.
brndnmtthws added a commit that referenced this issue Sep 29, 2016
@brndnmtthws
Optionally send SIGTERM after reload. (#321)
1b82aa0 
This is to address issues #5, #71, #267, #276, and #318.
@vixns vixns mentioned this issue Oct 4, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@h0tbird @brndnmtthws