Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Started new branch for recovery controller #96

Merged
merged 37 commits into from
May 14, 2020
Merged

Conversation

ANeumann82
Copy link
Contributor

Signed-off-by: Andreas Neumann [email protected]

Signed-off-by: Andreas Neumann <[email protected]>
reworked error handling
reworked client creation

Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
# Conflicts:
#	docs/parameters.md
#	kuttl-tests/.gitignore
#	kuttl-tests/Makefile
#	kuttl-tests/kuttl-test.yaml
#	kuttl-tests/render-test-templates.sh
#	operator/operator.yaml
#	templates/operator/operator.yaml.template
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82 ANeumann82 marked this pull request as ready for review May 11, 2020 17:33
@ANeumann82 ANeumann82 requested review from nfnt and zmalik May 11, 2020 17:33
Signed-off-by: Andreas Neumann <[email protected]>
Copy link
Contributor

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Have a few smaller comments, most of them almost nitpicks.

docs/evicting-nodes.md Show resolved Hide resolved
images/Dockerfile.recovery-controller Outdated Show resolved Hide resolved
images/Dockerfile.recovery-controller Outdated Show resolved Hide resolved
images/Dockerfile.recovery-controller Outdated Show resolved Hide resolved
images/cassandra-recovery/pkg/controller/controller.go Outdated Show resolved Hide resolved
images/cassandra-recovery/pkg/sts/statefulset.go Outdated Show resolved Hide resolved
images/cassandra-recovery/pkg/sts/statefulset.go Outdated Show resolved Hide resolved
@ANeumann82 ANeumann82 requested a review from nfnt May 12, 2020 10:46
Signed-off-by: Andreas Neumann <[email protected]>
Improved argument parsing in main.go

Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Added explicit options for recover controller

Signed-off-by: Andreas Neumann <[email protected]>
images/recovery/Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ANeumann82 !
this is looking great! just some nits

images/bootstrap/pkg/service/cassandra.go Outdated Show resolved Hide resolved
images/recovery/pkg/sts/statefulset.go Outdated Show resolved Hide resolved
images/recovery/pkg/sts/statefulset.go Outdated Show resolved Hide resolved
images/recovery/pkg/sts/statefulset.go Outdated Show resolved Hide resolved
Signed-off-by: Andreas Neumann <[email protected]>
Copy link
Contributor

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Changed recover base image to scratch
Updated health probe to include UJ state
Increased test delay for recovery test

Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82 ANeumann82 merged commit 9265e30 into master May 14, 2020
@ANeumann82 ANeumann82 deleted the an/recovery-controller branch May 14, 2020 17:23
porridge added a commit that referenced this pull request May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants