This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
add bootstrap binary to manage IPs #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmalik
force-pushed
the
zain/cluster-cm
branch
3 times, most recently
from
76fd5d0
to
9144a18
Compare
Signed-off-by: Zain Malik <[email protected]>
ANeumann82
approved these changes
May 7, 2020
Comment on lines
41
to
43
| if cfg.Annotations == nil { | ||
| return nil, fmt.Errorf("configmap %s has no annotations", configmap) | ||
| } |
There was a problem hiding this comment.
Is this an error that needs to be specifically handled?
I'd probably just maek the next line if cfg.Annotations != nil && cfg.Annotations[ANNOTATION_LOCK] == pod
But it may be an actual unexpected state
Co-authored-by: Andreas Neumann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR