This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Allow JMX rpc to be accessed from within the cluster #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
nfnt
suggested changes
Feb 24, 2020
| JVM_OPTS="$JVM_OPTS -Dcassandra.jmx.remote.port=$JMX_PORT" | ||
| # if ssl is enabled the same port cannot be used for both jmx and rmi so either | ||
| # pick another value for this property or comment out to use a random port (though see CASSANDRA-7087 for origins) | ||
| JVM_OPTS="$JVM_OPTS -Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT" | ||
|
|
||
| # turn on JMX authentication. See below for further options | ||
| JVM_OPTS="$JVM_OPTS -Dcom.sun.management.jmxremote.authenticate=true" | ||
| JVM_OPTS="$JVM_OPTS -Dcom.sun.management.jmxremote.authenticate=false" |
There was a problem hiding this comment.
Disabling authentication and SSL seems very insecure. This should be configurable and enabled by default.
There was a problem hiding this comment.
There is an explicit ticket for this. I'd prefer to focus on the actual backup & restore for now, as this might lead to bigger changes in the operator itself.
I do agree that this should be configurable and be enabled by default though.
Added Dockerfile change to template Signed-off-by: Andreas Neumann <[email protected]>
# Conflicts: # tests/suites/sanity/sanity_test.go
nfnt
approved these changes
Mar 24, 2020
Signed-off-by: Andreas Neumann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prework for backup/restore, so we can control the cluster/node from outside the running pod.
Signed-off-by: Andreas Neumann [email protected]