Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Started extending Parameters with additional attributes and types #162

Merged
merged 18 commits into from
Oct 28, 2020
Merged

Started extending Parameters with additional attributes and types #162

merged 18 commits into from
Oct 28, 2020

Conversation

ANeumann82
Copy link
Contributor

Signed-off-by: Andreas Neumann [email protected]

@ANeumann82
Started extending Parameters with additional attributes and types
d73b874 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Added more parameter descriptions
ace05fb 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
More adjustments to parameters, removed some unused params
2639883 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
More parameters
bebf3e8 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Moar parameter stuff
24a05e8 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
More param stuffs
5afb3ae 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Merge branch 'master' into an/extended-parameters
d2ee924
@ANeumann82
Updated generated parameters.md
98053ad 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Finished Cassandra Parameter update
dbed068 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Small adjustment
13dc0a8 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82 ANeumann82 marked this pull request as ready for review October 20, 2020 08:01
@nfnt
Copy link
Contributor

nfnt commented Oct 20, 2020

Please rebase on latest master to fix the docker build issue in CI.

nfnt
nfnt approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲
This looks like it was a lot of work! Thank you for re-organizing all the parameters, this looks amazing!

@ANeumann82
Can't use -no-unset etc.
051363d 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Remove double $$ from params.yaml.template
b2f74d7 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Ran missing format_files.sh
31c3bff 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Debug
ee564f8 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Hopefully fixed test
0205421 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
More test adjustments
dcd530f 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Added priorities for groups
d3baad1 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82
Re-add default that was deleted
f052d51 
Signed-off-by: Andreas Neumann <[email protected]>
@ANeumann82 ANeumann82 merged commit 2b810ca into master Oct 28, 2020
@ANeumann82 ANeumann82 deleted the an/extended-parameters branch October 28, 2020 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nfnt nfnt nfnt approved these changes

@porridge porridge Awaiting requested review from porridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ANeumann82 @nfnt