This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Use Toggle Task for deployment of cassandra exporter, bump to Kubernetes 1.16 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <[email protected]>
porridge
suggested changes
Jun 4, 2020
There was a problem hiding this comment.
Please update at least these two lines in docs to match the toggle task semantics for the parameter value. There might be more in that doc which assume the previous semantics.
It might make sense to coordinate with #131 as well
|
Waiting for merge and release of kudobuilder/kudo#1552 before we can merge this |
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
porridge
approved these changes
Jul 14, 2020
| @@ -17,5 +16,4 @@ spec: | |||
| selector: | |||
| matchLabels: | |||
| kudo.dev/instance: {{ .Name }} | |||
| kudo.dev/servicemonitor: "true" | |||
| {{ end }} | |||
| kudo.dev/servicemonitor: "true" | |||
There was a problem hiding this comment.
Can you please keep the trailing newline? It's visual noise when it's getting added and removed.
There was a problem hiding this comment.
Well, the change here was the removal of {{ end }} in the last line, not the trailing new line, but i've added it nonetheless back in.
ANeumann82
changed the title
Signed-off-by: Andreas Neumann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann [email protected]