Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[release/2.3] istio: Bump chart to v1.6.7 #483

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Aug 28, 2020

What type of PR is this?

Bug

What this PR does/ why we need it:

Backport #481 which removes a servicemonitor in istio that was pulling in bad targets.

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-70603
https://jira.d2iq.com/browse/COPS-6403

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

istio: The "kubernetes-service-monitor" service monitor has been removed.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo added ready backport This is a PR that backports to a branch labels Aug 28, 2020
@gracedo gracedo requested review from GoelDeepak, shaneutt and a team August 28, 2020 17:31
@gracedo gracedo self-assigned this Aug 28, 2020
@gracedo gracedo force-pushed the gracedo/release2.3_istio branch from 4ab5f6d to 5c1e8bf Compare August 28, 2020 17:36
@gracedo gracedo requested a review from joejulian August 28, 2020 17:36
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a couple of things before we move forward:

  1. fixes for CI issues
  2. we need to turn the Istio test group back on, it's currently disabled (commented out) in test/groups.yaml.

@gracedo gracedo force-pushed the gracedo/release2.3_istio branch from e1dc6e4 to 5630e89 Compare August 28, 2020 19:15
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ once CI is happy, given that we don't have any automated tests for the service monitors we should test manually that those are functional before merging.

@gracedo
Copy link
Contributor Author

gracedo commented Aug 28, 2020

Spun up a cluster using this branch of kba and verified that the kubernetes-service-monitor is no longer deployed with istio, and there are no longer enough unhealthy targets

$ k get servicemonitors -nistio-system
NAME                      AGE
envoy-stats-monitor       10m
kubernetes-pods-monitor   10m

image
image

@gracedo gracedo merged commit dcb423c into release/2.3 Aug 28, 2020
@gracedo gracedo deleted the gracedo/release2.3_istio branch August 28, 2020 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport This is a PR that backports to a branch ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants