-
Notifications
You must be signed in to change notification settings - Fork 21
azuredisk-csi-driver: snapshots feature #443
Conversation
Tested by deploying a cluster with this branch
|
dc4329e
to
93c57e1
Compare
Signed-off-by: Dimitri Koshkin <[email protected]>
93c57e1
to
3a7a80b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that this driver is one of the few addons left that are NOT tested automatically. This LGTM but let's make sure we put it through some manual testing before we merge.
👍 yep tested locally with the latest changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, glad to see another step in parity between our supported cloud providers
What type of PR is this?
Chore
What this PR does/ why we need it:
Just like in AWS EBS CSI driver and GCP CSI driver enable the Snapshot feature by default.
The chart already has an option for this , here just changing the default.
Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-70322
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist