Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

chore: bump external-dns version and also disable it by default #335

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

GoelDeepak
Copy link
Contributor

What type of PR is this?
Chore

What this PR does/ why we need it:
External-dns isn't configured to be usable by default. Hence, it make sense to disable it. This patch disable external-dns by default. Besides, it also updates the chart version

Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-69859

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

external-dns is disabled by default 

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@GoelDeepak GoelDeepak requested a review from a team as a code owner July 2, 2020 05:34
@GoelDeepak GoelDeepak self-assigned this Jul 2, 2020
Copy link
Contributor

@armandgrillet armandgrillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GoelDeepak GoelDeepak force-pushed the deepak/external-dns branch from c411847 to 939973d Compare July 2, 2020 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants