Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

[elasticsearch] data replica bump #327

Merged
merged 3 commits into from
Jun 29, 2020
Merged

[elasticsearch] data replica bump #327

merged 3 commits into from
Jun 29, 2020

Conversation

alejandroEsc
Copy link
Contributor

What type of PR is this?

Chore

What this PR does/ why we need it:

This allows us to bump the number of data nodes to 4 for better long term stability of the elastic search cluster over the period of time indicated by curator. This is a better and much needed suggested amount of data nodes than the usual 2 we have had on POCs.

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-66837

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Elasticsearch default data nodes has been increased to 4 by default.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@alejandroEsc alejandroEsc requested a review from a team as a code owner June 26, 2020 18:43
@alejandroEsc alejandroEsc self-assigned this Jun 26, 2020
samvantran
samvantran approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Beyond just the release notes, we should probably put this in the docs somewhere. Maybe in here for the defaults? https://docs.d2iq.com/ksphere/konvoy/1.5.0-beta/logging/recommendations/

Or as part of the upcoming KBA PR https://github.com/mesosphere/konvoy/pull/1639

Anyway, not needed for this PR.

@alejandroEsc
Copy link
Contributor Author

Looks good. Beyond just the release notes, we should probably put this in the docs somewhere. Maybe in here for the defaults? https://docs.d2iq.com/ksphere/konvoy/1.5.0-beta/logging/recommendations/

Or as part of the upcoming KBA PR mesosphere/konvoy#1639

Anyway, not needed for this PR.

Sounds good to me, its not a stated recommendation more than an opinion of what our defaults are. So, I can check where to update the docs on this info, but thought i should point that out.

@joejulian joejulian merged commit f957c65 into master Jun 29, 2020
@joejulian joejulian deleted the ae/elasticsearch branch June 29, 2020 22:57
@jieyu
Copy link
Contributor

jieyu commented Jul 2, 2020

@alejandroEsc that means we'll have to adjust our documentation on how many persistent volumes are needed? Can you link the relevant doc changes?

@alejandroEsc
Copy link
Contributor Author

@alejandroEsc that means we'll have to adjust our documentation on how many persistent volumes are needed? Can you link the relevant doc changes?

alright, will look into this asap

joejulian pushed a commit that referenced this pull request Jul 9, 2020
@alejandroEsc @samvantran @joejulian
[elasticsearch] data replica bump (#327)
ab2685a 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>
joejulian pushed a commit that referenced this pull request Jul 22, 2020
@alejandroEsc @samvantran @joejulian
[elasticsearch] data replica bump (#327)
8dc9811 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>
joejulian pushed a commit that referenced this pull request Jul 22, 2020
@alejandroEsc @samvantran @joejulian
[elasticsearch] data replica bump (#327)
eeba2de 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>
joejulian pushed a commit that referenced this pull request Jul 23, 2020
@alejandroEsc @samvantran @joejulian
[elasticsearch] data replica bump (#327)
eee4e55 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>
samvantran added a commit that referenced this pull request Aug 6, 2020
@alejandroEsc @samvantran
[elasticsearch] data replica bump (#327)
f488a6c 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>
@samvantran samvantran mentioned this pull request Aug 6, 2020
Merged
1 task
alejandroEsc added a commit that referenced this pull request Aug 6, 2020
@samvantran @alejandroEsc
[elasticsearch] data replica bump (#327) (#424)
e16f9ee 
* new revision created

* updated replicas to 4

Co-authored-by: Sam Tran <[email protected]>

Co-authored-by: Alejandro Escobar <[email protected]>
joejulian added a commit that referenced this pull request Aug 7, 2020
@joejulian
[elasticsearch] data replica bump (#327)
f595ddf 
* updated replicas to 4

Co-authored-by: Alejandro Escobar <[email protected]>
Co-authored-by: Sam Tran <[email protected]>
(cherry picked from commit f957c65)
@joejulian joejulian mentioned this pull request Aug 7, 2020
Merged
5 tasks
joejulian added a commit that referenced this pull request Aug 7, 2020
@joejulian
[elasticsearch] data replica bump (#327) (#429)
eaaebf0 
* updated replicas to 4

Co-authored-by: Alejandro Escobar <[email protected]>
Co-authored-by: Sam Tran <[email protected]>
(cherry picked from commit f957c65)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joejulian joejulian joejulian approved these changes

@samvantran samvantran samvantran approved these changes

@branden branden Awaiting requested review from branden

@gracedo gracedo Awaiting requested review from gracedo

Assignees

@alejandroEsc alejandroEsc

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alejandroEsc @jieyu @joejulian @samvantran