Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

composite values 2 #315

Merged
merged 12 commits into from
Jun 26, 2020
Merged

composite values 2 #315

merged 12 commits into from
Jun 26, 2020

Conversation

jr0d
Copy link
Contributor

@jr0d jr0d commented Jun 24, 2020

What type of PR is this?

Feature

What this PR does/ why we need it:

Adds valuesRemap definitions for auth-url

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-67977

Special notes for your reviewer:
delta commit:
2a3c473

Does this PR introduce a user-facing change?:

valuesRemap has been added for rewriting the forward authentication url in multiple addons. 

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@jr0d jr0d requested a review from a team as a code owner June 24, 2020 23:19
@jr0d jr0d changed the title Jr/d2iq 67977 composite values 2 composite values 2 Jun 24, 2020
@jr0d jr0d mentioned this pull request Jun 24, 2020
5 tasks
@joejulian joejulian added hold To put a PR on hold and removed hold To put a PR on hold labels Jun 25, 2020
@joejulian joejulian merged commit 98a50d4 into master Jun 26, 2020
@joejulian joejulian deleted the jr/d2iq-67977-composite-values-2 branch June 26, 2020 03:36
joejulian added a commit that referenced this pull request Jul 8, 2020
* chore: add revisions

* feat: add valuesRemap overrides for auth-url

* fix: remove revision

addon controller doesn't seem to find the updated revision.

* fix: sneak in a change to fix invalid cookies

* chore: add revision

* feat: add values remap to dashboard addon

* resolve pr collision

Co-authored-by: Joe Julian <[email protected]>
Co-authored-by: Sam Tran <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants