This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
traefik: bump to chart 1.72.19 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare for upgrade.
The chart change improves the charts by allowing extra SSL entrypoints being defined, and inherit SSL configurations from global SSL config. We observed that in some customer environment, they are using advanced configurations for their ingress, including turning on proxy protocol on the ingress. Previously, we use `extraConfigEntrypoints` to add the additional velero minio entrypoints for the velero addon. This basically means if they have any customization on the ingress entrypoint, we'll have to ask them to manually specifying those configs `extraConfigEntrypoints` again for the velero-minio entrypoint, which creates a very bad user experience. This chart change improves this experiecne by introducing `extraSSLEntrypoints` that will inherit global configurations so that the user does not have to do anything on the additional entrypoints. This patch update the Addon config accordingly to use the new `extraSSLEntrypoints`.
|
The AWS failure seems to be a flake due to the underlying infrastructure issue. Created https://jira.d2iq.com/browse/D2IQ-68751 to track |
joejulian
approved these changes
May 21, 2020
Closed
joejulian
pushed a commit
that referenced
this pull request
Jun 19, 2020
* traefik: copy from previous revision To prepare for upgrade. * traefik: bump to chart 1.72.19 The chart change improves the charts by allowing extra SSL entrypoints being defined, and inherit SSL configurations from global SSL config. We observed that in some customer environment, they are using advanced configurations for their ingress, including turning on proxy protocol on the ingress. Previously, we use `extraConfigEntrypoints` to add the additional velero minio entrypoints for the velero addon. This basically means if they have any customization on the ingress entrypoint, we'll have to ask them to manually specifying those configs `extraConfigEntrypoints` again for the velero-minio entrypoint, which creates a very bad user experience. This chart change improves this experiecne by introducing `extraSSLEntrypoints` that will inherit global configurations so that the user does not have to do anything on the additional entrypoints. This patch update the Addon config accordingly to use the new `extraSSLEntrypoints`.
joejulian
pushed a commit
that referenced
this pull request
Jul 22, 2020
* traefik: copy from previous revision To prepare for upgrade. * traefik: bump to chart 1.72.19 The chart change improves the charts by allowing extra SSL entrypoints being defined, and inherit SSL configurations from global SSL config. We observed that in some customer environment, they are using advanced configurations for their ingress, including turning on proxy protocol on the ingress. Previously, we use `extraConfigEntrypoints` to add the additional velero minio entrypoints for the velero addon. This basically means if they have any customization on the ingress entrypoint, we'll have to ask them to manually specifying those configs `extraConfigEntrypoints` again for the velero-minio entrypoint, which creates a very bad user experience. This chart change improves this experiecne by introducing `extraSSLEntrypoints` that will inherit global configurations so that the user does not have to do anything on the additional entrypoints. This patch update the Addon config accordingly to use the new `extraSSLEntrypoints`.
joejulian
pushed a commit
that referenced
this pull request
Jul 22, 2020
* traefik: copy from previous revision To prepare for upgrade. * traefik: bump to chart 1.72.19 The chart change improves the charts by allowing extra SSL entrypoints being defined, and inherit SSL configurations from global SSL config. We observed that in some customer environment, they are using advanced configurations for their ingress, including turning on proxy protocol on the ingress. Previously, we use `extraConfigEntrypoints` to add the additional velero minio entrypoints for the velero addon. This basically means if they have any customization on the ingress entrypoint, we'll have to ask them to manually specifying those configs `extraConfigEntrypoints` again for the velero-minio entrypoint, which creates a very bad user experience. This chart change improves this experiecne by introducing `extraSSLEntrypoints` that will inherit global configurations so that the user does not have to do anything on the additional entrypoints. This patch update the Addon config accordingly to use the new `extraSSLEntrypoints`.
joejulian
pushed a commit
that referenced
this pull request
Jul 23, 2020
* traefik: copy from previous revision To prepare for upgrade. * traefik: bump to chart 1.72.19 The chart change improves the charts by allowing extra SSL entrypoints being defined, and inherit SSL configurations from global SSL config. We observed that in some customer environment, they are using advanced configurations for their ingress, including turning on proxy protocol on the ingress. Previously, we use `extraConfigEntrypoints` to add the additional velero minio entrypoints for the velero addon. This basically means if they have any customization on the ingress entrypoint, we'll have to ask them to manually specifying those configs `extraConfigEntrypoints` again for the velero-minio entrypoint, which creates a very bad user experience. This chart change improves this experiecne by introducing `extraSSLEntrypoints` that will inherit global configurations so that the user does not have to do anything on the additional entrypoints. This patch update the Addon config accordingly to use the new `extraSSLEntrypoints`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does/ why we need it:
The chart change improves the charts by allowing extra SSL entrypoints
being defined, and inherit SSL configurations from global SSL config. We
observed that in some customer environment, they are using advanced
configurations for their ingress, including turning on proxy protocol on
the ingress.
Previously, we use
extraConfigEntrypointsto add the additional velerominio entrypoints for the velero addon. This basically means if they
have any customization on the ingress entrypoint, we'll have to ask them
to manually specifying those configs
extraConfigEntrypointsagain forthe velero-minio entrypoint, which creates a very bad user experience.
This chart change improves this experiecne by introducing
extraSSLEntrypointsthat will inherit global configurations so thatthe user does not have to do anything on the additional entrypoints.
This patch update the Addon config accordingly to use the new
extraSSLEntrypoints.Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-68705
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist