This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Joe/bump prometheus #205
Merged
Joe/bump prometheus #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroEsc
previously approved these changes
Mar 30, 2020
hectorj2f
previously approved these changes
Mar 30, 2020
jieyu
suggested changes
Mar 30, 2020
jieyu
reviewed
Mar 30, 2020
joejulian
force-pushed
the
joe/bump_prometheus
branch
from
5a17e3f to
97debc8
Compare
|
Looks like the following job is failing on a fresh install ➜ jie2 k describe pod -n kubeaddons prometheus-kubeaddons-grafana-default-dashboard-fvztw
...
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal Scheduled 2m49s default-scheduler Successfully assigned kubeaddons/prometheus-kubeaddons-grafana-default-dashboard-fvztw to ip-10-0-130-245.us-west-2.compute.internal
Warning FailedMount 46s kubelet, ip-10-0-130-245.us-west-2.compute.internal Unable to attach or mount volumes: unmounted volumes=[job], unattached volumes=[job default-token-c74s8]: timed out waiting for the condition
Warning FailedMount 41s (x9 over 2m49s) kubelet, ip-10-0-130-245.us-west-2.compute.internal MountVolume.SetUp failed for volume "job" : configmap "grafana-default-dashboard" not found |
This fixes a bug where a resource name had quotation marks embedded in the name, making it invalid and a configmap was named differently than the volume reference.
joejulian
force-pushed
the
joe/bump_prometheus
branch
from
97debc8 to
7a28d4c
Compare
jieyu
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does/ why we need it:
bump prometheus chart version from 8.8.2 to 8.8.3
This fixes a bug where a resource name had quotation marks embedded in the name, making it invalid.
Which issue(s) this PR fixes:
no issue
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist