This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
admission: introduce Service/Ingress validation + mutation #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a mutating admission webhook to
dklb
. This admission webhook is called whenever anIngress
orService
resource is created/updated and is responsible for performing validation of such resources, as well as injecting defaults for all the annotations supported bydklb
. This means that the creation of aService
resource such aswill be rejected upfront by
kubectl
:It also means that a
Service
resource created aswill be mutated by the admission webhook in order to look like this after creation:
Registration of the admission webhook is performed automatically by
dklb
, but can be disabled via feature gate shall the webhook ever prove to cause problems or be buggy.The TLS material required to register and serve the webhook is sourced from the
mke-cluster-info
configmap and from thedklb-tls
secret recently introduced to thekubernetes-cluster
package. Hence, the only action required by users/testers right now is to update their MKE clusters to the latest nightly build.