This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
chore: Bump edgelb version #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simão Reis <[email protected]>
|
|
sreis
force-pushed
the
sreis/bump-edge-lb
branch
2 times, most recently
from
f57b9f7 to
1957edb
Compare
GoelDeepak
previously approved these changes
Jul 3, 2019
jimmidyson
suggested changes
Jul 3, 2019
RELEASE-NOTES.adoc
Outdated
|
|
||
| === Breaking changes | ||
|
|
||
| * To use NLB functionality we now require EdgeLB built from master (commit https://github.com/mesosphere/dcos-edge-lb/commit/d3547ca23ba9b4a07b91e33562868b731330c855[d3547ca]) or version 1.4.0. |
There was a problem hiding this comment.
This should explain what the breaking change is.
There was a problem hiding this comment.
Done, lmk what you think.
docs/usage/00-installing.adoc
Outdated
| @@ -27,7 +27,7 @@ To install `dklb`, the following prerequisites must be met: | |||
| ** DC/OS must be v1.12.0 or later. | |||
| ** EdgeLB must be built and installed from the https://github.com/mesosphere/dcos-edge-lb/tree/master[`master`] branch. | |||
| A stub-universe is available, see https://github.com/mesosphere/dcos-edge-lb#stub-universe[here] for details. | |||
| *** EdgeLB https://docs.mesosphere.com/services/edge-lb/1.3/[`v1.3.0`] may be used instead, but some functionality will be missing. | |||
| *** EdgeLB https://docs.mesosphere.com/services/edge-lb/1.4/[`v1.4.0`] may be used instead, but some functionality will be missing. | |||
There was a problem hiding this comment.
Is there functionality missing in 1.4.0? Why use it then?
There was a problem hiding this comment.
I think the original intent was to say that you should use master. What do you think of changing to but some functionality might be missing?
| @@ -22,7 +22,7 @@ require ( | |||
| github.com/imdario/mergo v0.3.6 // indirect | |||
| github.com/json-iterator/go v1.1.5 // indirect | |||
| github.com/kr/pretty v0.1.0 // indirect | |||
| github.com/mesosphere/dcos-edge-lb v1.3.2-0.20190618110118-50a400af8d6f | |||
| github.com/mesosphere/dcos-edge-lb v1.3.2-0.20190628160932-d3547ca23ba9 | |||
There was a problem hiding this comment.
It's not released yet.
Signed-off-by: Simão Reis <[email protected]>
jimmidyson
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When this is merged we can tag v0.1.0-alpha.12 to share with the customer.