This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
kubernetes.dcos.io/edgelb-pool-name
annotation optional. In case a value isn't provided,dklb
computes the name of the target EdgeLB pool according to the following format:where
<mke-cluster-name>
is obtained from the MKE cluster's name by replacing all forward slashes with--
. This means that, for example, if the MKE cluster's name isdev/kubernetes01
, the EdgeLB pool for themy-svc
service in themy-namespace
namespace will beThe
--
separator is not ideal, but it is pretty much the only option we have given the limitations on the name of an EdgeLB Pool: