This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
DCOS-54009: Fix dklb picks up Ingress that has kubernetes.io/ingress.class annotation set to nginx #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2019 15:39
Signed-off-by: Simão Reis <[email protected]>
Signed-off-by: Simão Reis <[email protected]>
bmcustodio
force-pushed
the
sreis/dcos-54009
branch
2 times, most recently
from
5dd2db5 to
5a9705b
Compare
added 2 commits
May 22, 2019 17:18
Fixes DCOS-54009 Signed-off-by: Simão Reis <[email protected]>
Signed-off-by: Simão Reis <[email protected]>
bmcustodio
force-pushed
the
sreis/dcos-54009
branch
from
5a9705b to
a207635
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made the
genericControlleran interface and created afakeGenericControllerso we can inspect what is enqueued by theIngressController(andServiceController).Motivation and Context
A user reported that dklb picks up and Ingress that has
kubernetes.io/ingress.classannotation set to something other thanedgelb. The fix is to check if the ingress has the proper annotation before enqueuing it for processing. To make it easier to support the code going forward I made an effort to refactor thepkg/controllersso we can add unit tests.