This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
translator: support https-enabled l7 backends #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Pires <[email protected]>
pires
added
bug
bmcustodio
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which causes EdgeLB pools to respond with
502 BAD GATEWAYwhenever an HTTPS-enabled service was used as the backend for a givenIngress.The fix works by having HTTP and HTTPS variants for each backend, prefering the HTTPS variant but using the HTTP one as backup.
Due to the way health-checks are performed (using
check-sslfor the HTTPS-enabled variants and justcheckfor HTTP-enabled ones), things work as expected - either all HTTPS variants are used or all HTTP variants are used, depending on whether the target server supports TLS or not.