This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
translator: support tcp cloud load-balancing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 2, 2019 10:22
Signed-off-by: Bruno Custodio <[email protected]>
Signed-off-by: Bruno Custodio <[email protected]>
Signed-off-by: Bruno Custodio <[email protected]>
Signed-off-by: Bruno Custodio <[email protected]>
Co-Authored-By: bmcstdio <[email protected]>
pires
approved these changes
Feb 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TCP cloud load-balancing. This is done by allowing users to specify the following annotation:
This annotation must point at a
ConfigMapresource containing the required configuration object (as defined by EdgeLB). This object is passed unmodified to EdgeLB, which should handle provisioning of the cloud load-balancer.It should be noted that the included documentation must be changed as soon as possible in order to point at EdgeLB documentation detailing the required structure for the configuration object. The only part we should still document with respect to this is how to point at a given EdgeLB frontend, since we generate the frontend's names ourselves (
<cluster-name>:<namespace>:<name>:<port>).It should also be noted that, as of now, EdgeLB doesn't seem to report any errors that may occur due to an invalid configuration, making
dklbunable to provide feedback to the user in case of an error. When this is fixed,dklbshould start reporting these errors via Kubernetes events automatically.