Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return type for crm multifields phone, email, im #338

Closed
8 of 12 tasks
Tracked by #306
mesilov opened this issue Mar 1, 2023 · 0 comments · Fixed by #368
Closed
8 of 12 tasks
Tracked by #306

fix return type for crm multifields phone, email, im #338

mesilov opened this issue Mar 1, 2023 · 0 comments · Fixed by #368
Labels
2.x issue related with 2.x sdk version improve DX developer experience improvement scope CRM application scope CRM

Comments

@mesilov
Copy link
Owner

mesilov commented Mar 1, 2023 •
edited
Loading

  • add crm multifield type Email
  • add crm multifield type Phone
  • add crm multifield type Website
  • add crm multifield type IM
  • fix errors in Bitrix24\SDK\Services\CRM\Common\Result\AbstractCrmItem for return types
  • update annotations for contact, lead
  • add integration test for work with crm-multifields types
  • add dto objects for crm-multyfield types

test DX for scenarios

  • add contact with phone and email
  • update phone for contact
  • delete phone for contact
  • delete one phone for contact

we must use simple VO for phone, email, IM, website or string?
@mesilov mesilov mentioned this issue Mar 1, 2023
Closed
24 tasks
@mesilov mesilov added 2.x issue related with 2.x sdk version improvement improve DX developer experience scope CRM application scope CRM labels Mar 7, 2023
@mesilov mesilov closed this as completed Jan 4, 2024
@mesilov mesilov mentioned this issue Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x issue related with 2.x sdk version improve DX developer experience improvement scope CRM application scope CRM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bitrix24-php-sdk beta-1 mesilov/bitrix24-php-sdk
1 participant
@mesilov