Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove !<PlatformContext> tag from UniPipe YAML instance files #69

Open
felixzieger opened this issue Feb 16, 2022 · 3 comments
Open

Remove !<PlatformContext> tag from UniPipe YAML instance files #69

felixzieger opened this issue Feb 16, 2022 · 3 comments

Comments

@felixzieger
Copy link
Contributor

When working directly with UniPipe YAML files, the tag can cause problems.

Example: https://www.terraform.io/language/functions/yamldecode does not support any tags, that are not explicitly listed on their documentation.

unipipe CLI supports !<PlatformContext>, so the workaround for this would be to transform the files via unipipe-cli before parsing them to other tools.

@JohannesRudolph
Copy link
Member

yes I remember there was also quite a bit of hackage necessary in unipipe-cli to make it support that yaml tag... might be better to not emit them from the OSB in the first place

@DorukAkinci
Copy link
Contributor

Are we sure that we don't use this parameter at all? it is strange that why we put this in the first place 😄

@JohannesRudolph
Copy link
Member

@DorukAkinci i can't remember if this was a conscious decision or just happened as a by-product of the defaults of whatever YAML serializer the unipipe broker implementation happens to use (probably something written by spring?)

In any case, the unipipe cli would need to maintain backwards compatibility for existing repositories already using that tag. But for new services, removing that tag from the broker would be a non-breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants