Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual linkStyle behaves differently than default linkStyle #910

Closed
ppqn opened this issue Aug 22, 2019 · 4 comments · Fixed by #1132
Closed

Individual linkStyle behaves differently than default linkStyle #910

ppqn opened this issue Aug 22, 2019 · 4 comments · Fixed by #1132
Assignees
Labels
Area: Development Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@ppqn
Copy link

ppqn commented Aug 22, 2019

Describe the bug

When using linkStyle default, the link label is doesn't change; but when using linkstyle [number], the link label loses its background and doesn't hover over the link.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://mermaidjs.github.io/mermaid-live-editor/#/edit/eyJjb2RlIjoiZ3JhcGggTFI7XG4gIEFGe0FGfVxuICBVW1VdXG4gIFUtLVdJLS0-QUY7XG4gIFUtLU5MUC0tPkFGO1xuICBsaW5rU3R5bGUgZGVmYXVsdCBmaWxsOm5vbmUsc3Ryb2tlOmdyZWVuLHN0cm9rZS13aWR0aDoxcHg7XG4gIGxpbmtTdHlsZSAxIGZpbGw6bm9uZSxzdHJva2U6cmVkLHN0cm9rZS13aWR0aDoxcHg7IiwibWVybWFpZCI6eyJ0aGVtZSI6ImRlZmF1bHQifX0

  2. See the difference between WI and NLP

Code:

graph LR;
  AF{AF}
  U[U]
  U--WI-->AF;
  U--NLP-->AF;
  linkStyle default fill:none,stroke:green,stroke-width:1px;
  linkStyle 1 fill:none,stroke:red,stroke-width:1px;
Loading

Expected behavior
NLP should look like WI

Screenshots

Expected Annotation 2019-08-22 114050
Actual Annotation 2019-08-22 113927

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 8.2.3
@IOrlandoni IOrlandoni added Area: Development Contributor needed Retained Nonperishable Status: Approved Is ready to be worked on Topic: Styling Type: Bug / Error Something isn't working or is incorrect labels Sep 24, 2019
@GDFaber
Copy link
Member

GDFaber commented Dec 9, 2019

I've stumbled across this while working on #1088 today and got it basically fixed, but need to do more testing to make sure it's working properly with different settings. So I'd like to work on this as well.

@klemmchr
Copy link
Member

klemmchr commented Dec 9, 2019

I will assign you in the meanwhile. If you verified that you fixed it, make sure to mention both issues in your pr. Thanks!

@GDFaber
Copy link
Member

GDFaber commented Dec 9, 2019

Thanks, will do.

@GDFaber
Copy link
Member

GDFaber commented Dec 10, 2019

My PR is at #1132.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Development Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants