Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart is not rendered when we provide any other value except positive number #2472

Open
MayurMundekar opened this issue Nov 9, 2021 · 3 comments · Fixed by #4751
Open
Labels
Area: Development Contributor needed Graph: Pie Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@MayurMundekar
Copy link

MayurMundekar commented Nov 9, 2021

Hi Team,

Pie chart is not rendering If user enters any negative value or any string or blank value for datakey.
As per the syntax of Pie chart it will support only positive value but if user provide any other value it should give some syntax error or warning message.

Expected behavior
It should give syntax error or warning

Screenshots
If applicable, add screenshots to help explain your problem.

Code Sample
pie
title Key elements in Product X
"Calcium" : aa
"Potassium" : -12
"Magnesium" :

If we put above sample in editor it will not render anything

Desktop (please complete the following information):

  • OS: Windows
  • Browser chrome

Note:- I am using mermaid version 8.12.0

@MayurMundekar MayurMundekar added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 9, 2021
@Yash-Singh1 Yash-Singh1 added Area: Development Status: Approved Is ready to be worked on Graph: Pie and removed Status: Triage Needs to be verified, categorized, etc labels Nov 9, 2021
@MayurMundekar
Copy link
Author

Hi Team, @Yash-Singh1 may I know the updates on this ?

@nirname
Copy link
Contributor

nirname commented Jul 16, 2023

@Yokozuna59
Copy link
Member

Right now live editor says you have a lexical error

image

It already won't render, the proposal was to have a meaningful error message.

@Yokozuna59 Yokozuna59 linked a pull request Aug 28, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Development Contributor needed Graph: Pie Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
5 participants