Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move htmlLabells configuration out of flowchart to root #1431

Open
knsv opened this issue May 27, 2020 · 2 comments
Open

Move htmlLabells configuration out of flowchart to root #1431

knsv opened this issue May 27, 2020 · 2 comments
Labels
Status: Approved Is ready to be worked on Type: Enhancement New feature or request

Comments

@knsv
Copy link
Collaborator

knsv commented May 27, 2020

The configuration for whether or not to use htmlLabels is currently done with this configuration:

{
     flowchart:{
          htmlLabels: true
     }
}

With the new rendering engine more diagram types will get the option of htmlLabels which is why the option needs to move out of flowchart to the root as per below:

{
     htmlLabels: true
}

The change should be done without breaking backwards compatability. If a site integrator does not move the configuration mermaid should still look in the old location (for the time beeing). The current location is deprecated and in v9 support for it will be removed.

@knsv knsv added Type: Enhancement New feature or request Status: Triage Needs to be verified, categorized, etc Good first issue! Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels May 27, 2020
@github-actions github-actions bot added Status: Triage Needs to be verified, categorized, etc and removed Good first issue! Status: Approved Is ready to be worked on labels May 27, 2020
@jgreywolf jgreywolf self-assigned this Mar 8, 2023
@jgreywolf
Copy link
Contributor

Assigning myself for follow up

@jgreywolf jgreywolf added Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels Mar 8, 2023
@ghost ghost mentioned this issue Aug 31, 2023
@jgreywolf jgreywolf removed their assignment Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Approved Is ready to be worked on Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants