-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instanceOf(Element) doesn't work in iframe #3
Comments
oliviertassinari
changed the title
typeof Element doesn't work in iframe
instanceOf(Element) doesn't work in iframe
Feb 15, 2020
This is how we address the iframe problem in Popper 2 if it can be useful to you. https://github.com/popperjs/popper-core/blob/master/src/dom-utils/instanceOf.js |
@oliviertassinari Thanks for the report, seems the only way to handle this is using a custom validator. I'll look into solving this when I have some more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@merceyz I have noticed a warning with this demo https://material-ui.com/components/drawers/#responsive-drawer which lead my track down to:
typescript-to-proptypes/src/parser.ts
Lines 355 to 358 in adfcca4
instanceOf(Element)
doesn't work with different documents, e.g. iframe: facebook/prop-types#240 (comment).We were able to work around the problem in the Popper component with: https://github.com/mui-org/material-ui/blob/c1c66903b8cc3941d0e110f13f49122effdc0e47/packages/material-ui/src/Popper/Popper.js#L238.
Any idea on how we could best solve this problem?
The text was updated successfully, but these errors were encountered: