Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[Feature Request] Suggestions !#zh: 小建议 #2

Closed
1 of 6 tasks
ly525 opened this issue Jun 13, 2020 · 2 comments
Closed
1 of 6 tasks

[Feature Request] Suggestions !#zh: 小建议 #2

ly525 opened this issue Jun 13, 2020 · 2 comments

Comments

@ly525
Copy link

ly525 commented Jun 13, 2020 •
edited by dream-num
Loading

  • please add License file to the project

  • please use commit cz to standardize the commit message

  • please clear up the src/luckysheet-core.js

!#zh:

  • 请添加 license 文件，表明项目的开源协议

  • 请使用类似 commit cz 之类的工具，规范 commit message

  • 请整理 src/luckysheet-core.js 代码
@liuyang3688
Copy link

luckysheet-core.js 单文件确实太大了 源码读上去也费尽 抽时间优化吧

@dream-num
Copy link
Collaborator

感谢建议。
license 、 commit、模块化下一版本会改进和推出

@mnohn mnohn mentioned this issue Sep 28, 2020
Closed
dream-num pushed a commit that referenced this issue Jul 21, 2022
@akhaneev
Merge pull request #2 from alsundukov/experiments
590f7a1 
TBLFILTER-2253
JanoSlivka pushed a commit to JanoSlivka/Luckysheet that referenced this issue Aug 1, 2022
@titanDevelopers
Merge pull request dream-num#2 from titanDevelopers/bug/zooming
123c52b 
Fix zoom.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ly525 @liuyang3688