V111 problem - logging stops when using Hungarian locale

[ghost]

Can't find position, not record. Nor with default settings. It worked perfectly and stabile v110.

[mendhak]

I missed this one oops! That line there indicates some kind of error. You'd need to enable debug logging and have a look at the file to see what error is being thrown.

See: https://gpslogger.app/#troubleshooting

[ghost]

I created a debug file. From line 53?
debuglog.txt

[mendhak]

Got it! Here's the culprit.

java.util.UnknownFormatConversionException: Conversion = 'ó'
	at java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2782) ~[na:0.0]
	at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2812) ~[na:0.0]
	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2625) ~[na:0.0]
	at java.util.Formatter.parse(Formatter.java:2558) ~[na:0.0]
	at java.util.Formatter.format(Formatter.java:2505) ~[na:0.0]
	at java.util.Formatter.format(Formatter.java:2459) ~[na:0.0]
	at java.lang.String.format(String.java:2870) ~[na:0.0]
	at com.mendhak.gpslogger.common.Strings.getDescriptiveDurationString(Strings.java:99) ~[na:0.0]
	at com.mendhak.gpslogger.GpsLoggingService.getNotification(GpsLoggingService.java:507) ~[na:0.0]
	at com.mendhak.gpslogger.GpsLoggingService.showNotification(GpsLoggingService.java:565) ~[na:0.0]
	at com.mendhak.gpslogger.GpsLoggingService.onLocationChanged(GpsLoggingService.java:898) ~[na:0.0]
	at com.mendhak.gpslogger.GeneralLocationListener.onLocationChanged(GeneralLocationListener.java:72) ~[na:0.0]
	at android.location.LocationManager$LocationListenerTransport.acceptLocation(LocationManager.java:2742) ~[na:0.0]
	at android.location.LocationManager$LocationListenerTransport.lambda$enkW18B0WwpQkSIMmVChmQ2YwC8(Unknown Source:0) ~[na:0.0]
	at android.location.-$$Lambda$LocationManager$LocationListenerTransport$enkW18B0WwpQkSIMmVChmQ2YwC8.accept(Unknown Source:6) ~[na:0.0]
	at com.android.internal.util.function.pooled.PooledLambdaImpl.doInvoke(PooledLambdaImpl.java:292) ~[na:0.0]
	at com.android.internal.util.function.pooled.PooledLambdaImpl.invoke(PooledLambdaImpl.java:201) ~[na:0.0]
	at com.android.internal.util.function.pooled.OmniFunction.run(OmniFunction.java:97) ~[na:0.0]
	at android.os.Handler.handleCallback(Handler.java:938) ~[na:0.0]
	at android.os.Handler.dispatchMessage(Handler.java:99) ~[na:0.0]
	at android.os.Looper.loop(Looper.java:236) ~[na:0.0]
	at android.app.ActivityThread.main(ActivityThread.java:7864) ~[na:0.0]
	at java.lang.reflect.Method.invoke(Native Method) ~[na:0.0]
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:620) ~[na:0.0]
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1011) ~[na:0.0]

The problem is happening here,

gpslogger/gpslogger/src/main/java/com/mendhak/gpslogger/common/Strings.java

Lines 99 to 100 in fcd4e55

	descriptive = String.format(context.getString(R.string.time_hms_format),
	String.valueOf(hours), String.valueOf(minutes), String.valueOf(seconds));

and I think it's because the string format is coming from here, the %s is missing.

gpslogger/gpslogger/src/main/res/values-hu/strings.xml

Line 87 in fcd4e55

<string name="time_hms_format" formatted="false">%ó %p %mp</string>

[mendhak]

OK the fix is now pushed and I've tagged it as well so it should go in with the v119 release.

gpslogger/gpslogger/src/main/res/values-hu/strings.xml

Line 87 in 7555063

<string name="time_hms_format" formatted="false">%só %sp %smp</string>

[ghost]

You were fast. I tried it. Works well. THX. Sorry for the translation error.

[mendhak]

v119 is now on F-Droid and in the releases. I'm going around and closing some issues.