Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Send notification in different channel in case of error #1053

Closed
neilguertin opened this issue Feb 16, 2023 · 2 comments
Closed

[Feature request] Send notification in different channel in case of error #1053

neilguertin opened this issue Feb 16, 2023 · 2 comments
Milestone
v131

Comments

@neilguertin
Copy link

If a session is in progress but logging fails for some reason, the app should send a notification to let the user know.

I generally leave the app running 24/7 and have hidden the constant notification from the device's notification settings. Several times now the logging has failed and I only noticed several days later because I happened to open the app.

The logging has failed for several reasons, for example when logging to a local file and storage fills up or permissions get changed. Basically any time red warning text gets printed to log view.

It might be useful to have notifications for warnings too (timeout reached, etc) but they should be in a separate channel from errors.
@JacksonChen666 JacksonChen666 mentioned this issue May 12, 2024
Closed
mendhak added a commit that referenced this issue May 26, 2024
@mendhak
New error notification channel for critical errors such as lack of pe…
93fe76b 
…rmissions or unable to write file.

Issue #1053
Issue #1158
mendhak added a commit that referenced this issue May 26, 2024
@mendhak
New error notification channel for critical errors such as lack of pe…
c62b680 
…rmissions or unable to write file.

Issue #1053
Issue #1138
mendhak added a commit that referenced this issue May 26, 2024
@mendhak
Stabilize the app when permissions have been revoked. Moved the start…
95fa61a 
… service to only after the permission check is complete.

In the stop service, only stop the service if notifications are enabled, due to a weird scenario where the service might start and immediately end due to lack of notifications, resulting in an app crash.
How did we end up like this.
Issue #1138
Issue #1053
@mendhak mendhak added this to the v131 milestone May 26, 2024
@mendhak mendhak mentioned this issue May 26, 2024
Merged
mendhak added a commit that referenced this issue May 27, 2024
@mendhak
Show a notification if file write failure occurs. Continues logging a…
708b60b 
…nyway, except for NMEA, which stops logging. This is because NMEA has a high frequency of writes.

Issue #1138 #1053
@mendhak
Copy link
Owner

mendhak commented May 27, 2024

I've done some work on this yesterday.
Discussion and test APK is here: #1138
I'll close this thread and move to that one.

@mendhak mendhak closed this as completed May 27, 2024
@mendhak
Copy link
Owner

mendhak commented Jul 10, 2024

v131 is in the releases and FDroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v131
Development

No branches or pull requests
2 participants
@mendhak @neilguertin