From 3d168ecf0980055f11d6ffa4fb88c3cb99daf5ac Mon Sep 17 00:00:00 2001 From: Toni Lastre Date: Fri, 15 Dec 2023 21:15:23 +0100 Subject: [PATCH 1/3] Chore: Add release 0.4.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7b8a393..1fede94 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@memgraph/orb", - "version": "0.4.1", + "version": "0.4.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@memgraph/orb", - "version": "0.4.1", + "version": "0.4.2", "license": "Apache-2.0", "dependencies": { "d3-drag": "3.0.0", diff --git a/package.json b/package.json index de4b824..ac46681 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@memgraph/orb", - "version": "0.4.1", + "version": "0.4.2", "description": "Graph visualization library", "engines": { "node": ">=16.0.0" From ce3e51f72df06da83d781d5539beb5cf4a51aefe Mon Sep 17 00:00:00 2001 From: Markus Nissl Date: Fri, 15 Dec 2023 21:17:29 +0100 Subject: [PATCH 2/3] Fix: resizeObserver is not unobserved (fixes #81) (#82) --- src/views/default-view.ts | 6 ++++-- src/views/map-view.ts | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/views/default-view.ts b/src/views/default-view.ts index 2eb4688..df1af3b 100644 --- a/src/views/default-view.ts +++ b/src/views/default-view.ts @@ -39,6 +39,7 @@ export type IDefaultViewSettingsInit = export class DefaultView implements IOrbView> { private _container: HTMLElement; + private _resizeObs: ResizeObserver; private _graph: IGraph; private _events: OrbEmitter; private _strategy: IEventStrategy; @@ -96,8 +97,8 @@ export class DefaultView implements IO this._settings.render = this._renderer.getSettings(); // Resize the canvas based on the dimensions of its parent container
. - const resizeObs = new ResizeObserver(() => this._handleResize()); - resizeObs.observe(this._container); + this._resizeObs = new ResizeObserver(() => this._handleResize()); + this._resizeObs.observe(this._container); this._handleResize(); this._d3Zoom = zoom() @@ -215,6 +216,7 @@ export class DefaultView implements IO } destroy() { + this._resizeObs.unobserve(this._container); this._renderer.removeAllListeners(); this._simulator.terminate(); this._canvas.outerHTML = ''; diff --git a/src/views/map-view.ts b/src/views/map-view.ts index 8aa9ad3..7f4c50b 100644 --- a/src/views/map-view.ts +++ b/src/views/map-view.ts @@ -59,6 +59,7 @@ export type IMapViewSettingsUpdate = P export class MapView implements IOrbView> { private _container: HTMLElement; + private _resizeObs: ResizeObserver; private _graph: IGraph; private _events: OrbEmitter; private _strategy: IEventStrategy; @@ -106,8 +107,8 @@ export class MapView implements IOrbVi this._settings.render = this._renderer.getSettings(); // Resize the canvas based on the dimensions of it's parent container
. - const resizeObs = new ResizeObserver(() => this._handleResize()); - resizeObs.observe(this._container); + this._resizeObs = new ResizeObserver(() => this._handleResize()); + this._resizeObs.observe(this._container); this._handleResize(); this._leaflet = this._initLeaflet(); @@ -166,6 +167,7 @@ export class MapView implements IOrbVi } destroy() { + this._resizeObs.unobserve(this._container); this._renderer.removeAllListeners(); this._leaflet.off(); this._leaflet.remove(); From 87b574c16b5784b2d585a254f4d993c1ac56f635 Mon Sep 17 00:00:00 2001 From: Toni Lastre Date: Fri, 15 Dec 2023 21:18:37 +0100 Subject: [PATCH 3/3] Chore: Add CHANGELOG update --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d1c1305..4d95295 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## 0.4.2 + +### Fix + +* Fix: resizeObserver is not unobserved (#82) (fixes #81) - by @markusnissl + ## 0.4.1 ### Fix