Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memfault_platform_coredump_save_begin is documented as being weak no-op, but is not in ESP-IDF #77

Closed
finger563 opened this issue Oct 21, 2024 · 4 comments

Comments

@finger563
Copy link

Per the documentation and within the base sdk memfault_platform_coredump_save_begin() is listed as a weakly defined symbol that can be overridden by user code.

However, the esp-idf platform port overrides this here.

@noahp
Copy link
Contributor

noahp commented Oct 21, 2024

Hi @finger563 , you're correct! We'll update the SDK to make that change. Do you have a timeline for when you'd need an SDK release with the fix?

@finger563
Copy link
Author

We have some platform integration deliverable timelines which are due by Nov 11, though of course the earlier the better for completing the integration and testing.

@noahp
Copy link
Contributor

noahp commented Oct 21, 2024

Thanks @finger563 ! We'll schedule an SDK release for this week, I'll post back here when it's shipped.

@gminn
Copy link
Member

gminn commented Oct 24, 2024

@finger563 This has been addressed in v1.16.0, the release that went out today. Please review the Changelog here for details, and let us know if you have any other questions!

@gminn gminn closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants