-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for new BATCH
message type in taps and targets
#904
Conversation
BATCH
message type (aka FAST_SYNC
spec)
d685a8c
to
4d28791
Compare
Codecov Report
@@ Coverage Diff @@
## main #904 +/- ##
==========================================
+ Coverage 81.18% 81.77% +0.59%
==========================================
Files 36 37 +1
Lines 3555 3742 +187
Branches 718 746 +28
==========================================
+ Hits 2886 3060 +174
- Misses 492 500 +8
- Partials 177 182 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b9e8e9b
to
5a7cb5f
Compare
5a7cb5f
to
a0848c6
Compare
0e4bc33
to
6752917
Compare
080eefe
to
b88f56a
Compare
f855285
to
3cb2ee3
Compare
@kgpayne @aaronsteers this is ready for final (🤞) review 😄 |
BATCH
message type (aka FAST_SYNC
spec)BATCH
message type support for taps and targets
BATCH
message type support for taps and targetsBATCH
message type in taps and targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarrmondragon - I made two small tweaks in the docs page. For my part, I think this is ready to go. Fantastic work! 🚀
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
d6a8595
to
c4861c1
Compare
c4861c1
to
bf06a9c
Compare
@aaronsteers target now extracts storage root from absolute URLs presented in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarrmondragon - A few docs tweaks proposed. Nothing here is blocking but hopefully these small tweaks increase clarity overall.
@edgarrmondragon - Thanks very much for the work to pass and accept absolute paths. I proposed a few docs updates. Feel free to merge when ready, per mine and @cjohnhanson's approval here on the PR. |
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
Related:
BATCH
message type (akaFAST_SYNC
spec) #9📚 Documentation preview 📚: https://meltano-sdk--904.org.readthedocs.build/en/904/batch.html