Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing error when using a list as a default value in singer_sdk.typing.Property #782

Closed
edgarrmondragon opened this issue Jul 1, 2022 · 0 comments · Fixed by #781
Closed

Typing error when using a list as a default value in singer_sdk.typing.Property #782

edgarrmondragon opened this issue Jul 1, 2022 · 0 comments · Fixed by #781
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

mypy is complaining on taps that use a list as the default value:

error: Argument "default" to "Property" has incompatible type "List[<nothing>]"; expected "Union[str, float, None]"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow lists and dictionaries as types for default JSON values meltano/sdk
1 participant
@edgarrmondragon