Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast environment variables config values into their respective JSON schema type #390

Closed
MeltyBot opened this issue May 20, 2022 · 4 comments · Fixed by #2637
Closed

Cast environment variables config values into their respective JSON schema type #390

MeltyBot opened this issue May 20, 2022 · 4 comments · Fixed by #2637

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/393

Originally created by @edgarrmondragon on 2022-05-20 18:16:14


Summary

Currently only arrays of strings are parsed: value1,value2 -> ["value1", "value2"]. A similar process for number, boolean and integer would be valuable.

Proposed benefits

  • Users can fully rely on environment variables and .env to configure their taps
  • Richer data types can be used for environment variables

Proposal details

We already have some functions to check for data types in https://gitlab.com/meltano/sdk/-/blob/main/singer_sdk/helpers/_typing.py, so we could extend and leverage those when parsing environment variables.

Best reasons not to build

Support for environment variables is not common in the Singer ecosystem.

@MeltyBot
Copy link
Contributor Author

@labelsync-manager labelsync-manager bot added the kind/Feature New feature or request label Jun 23, 2022
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Jul 18, 2023

Very much still relevant. See MeltanoLabs/tap-jira#15 (comment)

Copy link

stale bot commented Jul 17, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment