Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Made auth_headers and auth_params of APIAuthenticatorBase simple instance attributes instead of decorated properties #2596

Merged

Conversation

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/auth-header-params-attrs branch from 487e7ae to 7c2c7fb Compare August 9, 2024 00:03
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #2596 will not alter performance

Comparing edgarrmondragon/refactor/auth-header-params-attrs (0270bcf) with main (75eb494)

Summary

✅ 6 untouched benchmarks

…ase` simple instance attributes instead of decorated properties

Closes #925
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/auth-header-params-attrs branch from 7c2c7fb to 0270bcf Compare August 9, 2024 00:10
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (75eb494) to head (0270bcf).
Report is 120 commits behind head on main.

Files with missing lines Patch % Lines
singer_sdk/authenticators.py 20.00% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2596   +/-   ##
=======================================
  Coverage   89.47%   89.48%           
=======================================
  Files          58       58           
  Lines        4800     4792    -8     
  Branches      937      934    -3     
=======================================
- Hits         4295     4288    -7     
+ Misses        352      351    -1     
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 5fc0f75 into main Aug 9, 2024
33 of 35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/auth-header-params-attrs branch August 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant