Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit supported Python versions in --about output to existing ones #2180

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 25, 2024

Closes #2177


📚 Documentation preview 📚: https://meltano-sdk--2180.org.readthedocs.build/en/2180/

@edgarrmondragon edgarrmondragon linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #2180 will not alter performance

Comparing 2177-bug-supported-python-versions-from-about-go-up-to-316 (f4eb512) with main (47609eb)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47609eb) 88.39% compared to head (f4eb512) 88.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
+ Coverage   88.39%   88.49%   +0.09%     
==========================================
  Files          54       54              
  Lines        4689     4711      +22     
  Branches      955      961       +6     
==========================================
+ Hits         4145     4169      +24     
+ Misses        386      384       -2     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2177-bug-supported-python-versions-from-about-go-up-to-316 branch from 67c1f6f to 6a25ed8 Compare January 25, 2024 18:26
@edgarrmondragon edgarrmondragon force-pushed the 2177-bug-supported-python-versions-from-about-go-up-to-316 branch from cb8c4ee to f4eb512 Compare January 25, 2024 18:55
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 25, 2024 19:09
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners January 25, 2024 19:09
@edgarrmondragon edgarrmondragon merged commit 392b1c7 into main Jan 25, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the 2177-bug-supported-python-versions-from-about-go-up-to-316 branch January 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Supported Python Versions from --about go up to 3.16
1 participant